Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity: show if files are hidden or not #25926

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Activity: show if files are hidden or not #25926

merged 1 commit into from
Mar 4, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 4, 2021

I'm not 100% sure I like the wording like this. But good enough for a first version It hink.

image

@rullzer
Activity: show if files are hidden or not
997259d 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 22 milestone Mar 4, 2021
nickvergessen
nickvergessen approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this works for renaming, but not for eg mv a/b.txt c/.d.txt (so changing parent and name)

@rullzer
Copy link
Member Author

rullzer commented Mar 4, 2021

So this works for renaming, but not for eg mv a/b.txt c/.d.txt (so changing parent and name)

ah fair enough. well baby steps I guess

PVince81
PVince81 approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 9da935c into master Mar 4, 2021
@PVince81 PVince81 deleted the enh/activity/hidden_files branch March 4, 2021 15:44
@rullzer
Copy link
Member Author

rullzer commented Mar 4, 2021

/backport to stable21

@rullzer
Copy link
Member Author

rullzer commented Mar 4, 2021

/backport to stable20

This was referenced Mar 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: activity and notification
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @nickvergessen @PVince81