-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only mark migrations as installed after execution #25924
Only mark migrations as installed after execution #25924
Conversation
The problem is that if a developer creates a structural error in their migration file, they will already be marked as executed and an not be rerun. Signed-off-by: Joas Schilling <coding@schilljs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this cause problems if part of it has been applied?
Well currently all are marked as executed even if nothing is executed... This basically boils down to the "code safe for your step and depend on others", e.g.
|
I could add the current case: A fix to the migration file was released, but it was not possible to re-execute it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
@nickvergessen Do we want to backport this? |
/backport to stable21 |
The problem is that if a developer creates a structural error in their migration file,
they will already be marked as executed and an not be rerun.
Happened to @Rello in the analytics app.