Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appconfig to always show the unique label of a sharee #25915

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

juliusknorr
Copy link
Member

It is quite common in larger environments or in setups that use a lot of guest users that with sharing autocompletion the display name doesn't give enough hint on whom a file is shared with in the end. This PR adds a appconfig flag that can be set in order to always show the email or userid unique shareee label if this is wanted by the admin.

image

occ config:app:set files_sharing always_show_unique --value 'yes'

@juliusknorr
Copy link
Member Author

As some additional note, in older versions we just had a tooltip on the avatar with the userid which was used as kind of a workaround for this, but with the new multiselect users cannot really see who they share a file to then.

@rullzer
Copy link
Member

rullzer commented Mar 4, 2021

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/noid/option-always-show-unique-label branch from 4c3511f to 5a0d43d Compare March 4, 2021 07:40
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/option-always-show-unique-label branch from 5a0d43d to 69c2864 Compare March 4, 2021 08:25
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 4, 2021
@blizzz blizzz merged commit c3361a2 into master Mar 4, 2021
@blizzz blizzz deleted the bugfix/noid/option-always-show-unique-label branch March 4, 2021 11:11
@juliusknorr
Copy link
Member Author

/backport to stable21

@juliusknorr
Copy link
Member Author

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants