Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating two share links when password is enforced #25602

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Avoid creating two share links when password is enforced #25602

merged 1 commit into from
Feb 22, 2021

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 12, 2021 •
edited
Loading

Steps to reproduce:

  • Enforce password on share links
  • Create a new share link and click the -> button next to the password input or click create share

💥 See that the share link was created twice

The main reason is that the close of the modal also triggers the share creation

@skjnldsv skjnldsv self-requested a review February 19, 2021 10:26
@skjnldsv skjnldsv added 2. developing Work in progress bug labels Feb 19, 2021
@skjnldsv skjnldsv force-pushed the bugfix/noid/only-create-share-once branch from 367b63d to c534e8b Compare February 19, 2021 11:02
@skjnldsv skjnldsv marked this pull request as ready for review February 19, 2021 11:02
@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: sharing and removed 2. developing Work in progress labels Feb 19, 2021
@skjnldsv skjnldsv added this to the Nextcloud 22 milestone Feb 19, 2021
@skjnldsv
Copy link
Member

/backport to stable21

@skjnldsv
Copy link
Member

/backport to stable20

@skjnldsv
Copy link
Member

/backport to stable19

@skjnldsv
Copy link
Member

/compile amend /

@juliusknorr @npmbuildbot-nextcloud
Avoid creating two share links when password is enforced
9073c09 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the bugfix/noid/only-create-share-once branch from c534e8b to 9073c09 Compare February 19, 2021 11:16
@skjnldsv skjnldsv merged commit 1eca8d2 into master Feb 22, 2021
@skjnldsv skjnldsv deleted the bugfix/noid/only-create-share-once branch February 22, 2021 11:08
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 22, 2021
This was referenced Feb 22, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@PVince81 PVince81 Awaiting requested review from PVince81

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @skjnldsv @ChristophWurst