Add SGI and TGA preview support #25268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enh/previews/sgi-tga
branch
from
af4c91b
to
d47b84b
Compare
skjnldsv
requested review from
ChristophWurst,
rullzer,
nickvergessen and
PVince81
skjnldsv
added
3. to review
skjnldsv
commented
Jan 22, 2021
Comment on lines
+361
to
+362
| John Molakvoæ <skjnldsv@protonmail.com> John Molakvoæ <skjnldsv@users.noreply.github.com> | ||
| John Molakvoæ <skjnldsv@protonmail.com> John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> |
There was a problem hiding this comment.
I know it's not directly related, but it updated some license header here as well, I guess it's still not that big of a change. Fell free to tell me if that's really stupid :)
There was a problem hiding this comment.
add it to https://github.com/nextcloud/server/blob/master/.mailmap to map all those git user+email combinations to one entry
rullzer
requested changes
Jan 22, 2021
skjnldsv
force-pushed
the
enh/previews/sgi-tga
branch
from
168828a
to
c401217
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enh/previews/sgi-tga
branch
from
c401217
to
0bc9e3c
Compare
ChristophWurst
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGI AND TGA are supported by imagemagick natively
https://imagemagick.org/script/formats.php
Sample files: https://filesamples.com/formats/sgi https://filesamples.com/formats/tga