Moving between storages is not a rename

[rullzer]

For #16419
Based on #16696

[rullzer]

So to test enable sever side encryption

1. userA has a folderA
2. folderA has a child folderB
3. folderB has a child folderC
4. fodlerC has a file foo.txt
5. userA shares folderA to userB
6. userC shares a folderD to userB
7. userB moves folderB to folderD

Before the encrypted flag was not properly set. Now it is.
@icewind1991 I need some help here to check things.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1801: failure

acceptance-users

• tests/acceptance/features/users.feature:47

Show full log

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[rullzer]

Master is Nextcloud 22 now.
If this should go into 21 it should be backported.

[PVince81]

@icewind1991 since you've been working on copy recently, any hints on this ?

[PVince81]

I've tested the steps above without this PR and moving worked file and the file can be downloaded properly.
So either I'm missing some details about the env or the problem has disappeared recently on master (2a63219)

[PVince81]

also works on v20.0.10 without patching.

note: I've created the users on the CLI and made sure to login as them before sharing, just in case. Not sure if the test case implies that the target users did NOT log in and might not be fully initialized.

[PVince81]

aha, I jumped back in time to a commit close to the date of this PR: v21.0.0beta7 (without the PR applied)
here I am able to reproduce the problem and the log says "bad signature", and the "encrypted" version of "foo.txt" is 0 in the target, even though the file is encrypted

then I upgraded to v21.0.4 and ran occ encryption:fix-encrypted-version userC and it was able to set the version back to 1, and then the file could be downloaded again

[PVince81]

just in case, I tested v21.0.0beta7 with transfer ownership, transferring "folderB" to user B without any sharing in place at it worked fine, no troubles with the file "foo.txt"

[PVince81]

so one theory is that this fix is not really needed any more, but would be good to know what other code path has fixed the issue

[PVince81]

closing as obsolete