Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do cachejail search filtering in sql #25136

Merged
merged 5 commits into from
Mar 15, 2021
Merged

do cachejail search filtering in sql #25136

merged 5 commits into from
Mar 15, 2021

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 14, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Jan 14, 2021
@nextcloud nextcloud deleted a comment from faily-bot bot Jan 19, 2021
@icewind1991 icewind1991 force-pushed the cachejail-search-filter branch 2 times, most recently from 052644e to 03ddc59 Compare January 25, 2021 13:25
@nextcloud nextcloud deleted a comment from faily-bot bot Jan 25, 2021
@icewind1991 icewind1991 force-pushed the cachejail-search-filter branch 2 times, most recently from fb8ea61 to 4044fe7 Compare January 25, 2021 14:40
@rullzer
Copy link
Member

rullzer commented Jan 26, 2021

CI is not happy

@icewind1991
do cachejail search filtering in sql
a44aab1 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix cachjail searching for root
27f9df2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix search in nested jails
5ae0be0 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
adjust tests
e511a53 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the cachejail-search-filter branch 2 times, most recently from 575fd14 to 4f7d650 Compare January 26, 2021 15:12
@icewind1991
only use share cacheentry when available
6ecf33b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

Ci is happy

@icewind1991 icewind1991 mentioned this pull request Jan 26, 2021
Closed
@wiswedel
Copy link
Contributor

@icewind1991 To what data extent has this been tested? What grade of performance improvement does it guarantee?

@icewind1991
Copy link
Member Author

The improvement this will make is massively depended on setup and usage details, trying to give any number would be completely meaningless.

@jospoortvliet
Copy link
Member

The improvement this will make is massively depended on setup and usage details, trying to give any number would be completely meaningless.

how much faster will it make getting the results of files on our instance? That'd be one concrete case 🚀

@rullzer
Copy link
Member

rullzer commented Jan 27, 2021

The improvement this will make is massively depended on setup and usage details, trying to give any number would be completely meaningless.

how much faster will it make getting the results of files on our instance? That'd be one concrete case rocket

it will make it 9 faster (not 9x just 9).

On a more serious note. We will know once we measure it. But don't expect that all of sudden everything flies. But it helps.

@icewind1991
Copy link
Member Author

ping @juliushaertl

PVince81
PVince81 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comment

lib/private/Files/Cache/Wrapper/CacheJail.php Show resolved Hide resolved
lib/private/Files/Cache/Wrapper/CacheJail.php Show resolved Hide resolved
@PVince81 PVince81 merged commit e559afb into master Mar 15, 2021
@PVince81 PVince81 deleted the cachejail-search-filter branch March 15, 2021 16:45
@icewind1991
Copy link
Member Author

/backport to stable21

@icewind1991
Copy link
Member Author

/backport to stable20

@icewind1991
Copy link
Member Author

/backport to stable19

This was referenced Mar 15, 2021
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 15, 2021
Merged
@icewind1991 icewind1991 mentioned this pull request Mar 17, 2021
Closed
@jknockaert jknockaert mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @rullzer @wiswedel @jospoortvliet @PVince81