Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend ILDAPProvider to allow reading arbitrairy ldap attributes for users #25128

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

icewind1991
Copy link
Member

For allowing things like #24955 using public interfaces

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 14, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Jan 14, 2021
lib/public/LDAP/ILDAPProvider.php Outdated Show resolved Hide resolved
apps/user_ldap/lib/LDAPProvider.php Outdated Show resolved Hide resolved
…users

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

@blizzz done

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but some tests would be nice.

@MorrisJobke
Copy link
Member

/backport to stable20

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Co-authored-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

For allowing things like #24955 using public interfaces

Mind to submit this with the new API?

@MorrisJobke
Copy link
Member

Mind to submit this with the new API?

cc @blizzz @icewind1991

@MorrisJobke
Copy link
Member

For allowing things like #24955 using public interfaces

Mind to submit this with the new API?

@blizzz @icewind1991 Any news here?

@blizzz
Copy link
Member

blizzz commented Mar 29, 2021

Last was #25010 (comment)

@icewind1991
Copy link
Member Author

#26397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants