-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add our own db column types via the public API #25089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
rullzer,
nickvergessen,
MorrisJobke,
blizzz,
juliusknorr and
kesselb
January 12, 2021 09:25
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1292: failureacceptance-header
Show full log
|
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/ocp-db-types
branch
from
January 12, 2021 13:09
6814b05
to
c1d4f81
Compare
nickvergessen
approved these changes
Jan 12, 2021
rullzer
approved these changes
Jan 12, 2021
blizzz
approved these changes
Jan 12, 2021
This was referenced Jan 12, 2021
This was referenced Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #24948 we need to adjust lots of apps since the doctrine type constants were used directly. To prevent this data leakage, we should have our own set of supported db column types.
So this is not a simple copy of the upstream types, but a shortened version that only has the things that works across all of our DBs.
One might argue that some of the more advanced types do not make sense in combination with our query builder or db mappers, because those either map to string or another primitive. But I think it still makes sense to have the db column types in the desired format, if applicable. Then the DB will not only ensure the type is correct, it can also optimize for storage and retrieval.
Ref https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/types.html
This PR consists of two commits/parts. The first one adds the new constants, the second one updates the server code to make use of them.
I'll update the docs accordingly when we settled on the exported types.