Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show icon only with dnd status in the message #23114

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

juliusknorr
Copy link
Member

Required for the status widget once we have nextcloud-libraries/nextcloud-vue#1422

@gary-kim
Copy link
Member

/compile amend /

@nickvergessen
Copy link
Member

It needs a rebuild anyway after #23113 is in, but well so be it :P

@rullzer
Copy link
Member

rullzer commented Oct 2, 2020

/backport to stable20

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nickvergessen nickvergessen force-pushed the bugfix/noid/user_status-show-icon branch from 7da8dc3 to d0237bf Compare October 2, 2020 12:06
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/user_status-show-icon branch from d0237bf to 97f9b18 Compare October 2, 2020 12:14
@nickvergessen
Copy link
Member

Bildschirmfoto von 2020-10-02 14-15-09

Uses the non-compact mode now, so icon + status are displayed (when suitable)

@faily-bot
Copy link

faily-bot bot commented Oct 2, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33570: failure

acceptance-users

  • tests/acceptance/features/users.feature:4
Show full log
  Scenario: create a new user                                       # /drone/src/tests/acceptance/features/users.feature:4
    Given I act as Jane                                             # ActorContext::iActAs()
    And I am logged in as the admin                                 # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                    # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                 # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                       # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    When I create user unknownUser with password 123456acb          # UsersSettingsContext::iCreateUserWithPassword()
    Then I see that the list of users contains the user unknownUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

@rullzer rullzer merged commit 0f7e2f3 into master Oct 2, 2020
@rullzer rullzer deleted the bugfix/noid/user_status-show-icon branch October 2, 2020 14:58
@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants