Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ellipsized unified search results visible on hover #22420

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

ChristophWurst
Copy link
Member

This helps with results like

Bildschirmfoto von 2020-08-25 13-40-25

@nickvergessen
Copy link
Member

Can we also highlight the subline and ellipsis on the context of the search term?

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Aug 25, 2020
@ChristophWurst
Copy link
Member Author

Can we also highlight the subline and ellipsis on the context of the search term?

@skjnldsv?

@rullzer rullzer mentioned this pull request Aug 26, 2020
19 tasks
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/unified-search-ellipsized-title-subline branch from 0db675f to 06f8c54 Compare August 26, 2020 18:30
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 26, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 26, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32359: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@skjnldsv skjnldsv merged commit c1bba2d into master Aug 27, 2020
@skjnldsv skjnldsv deleted the fix/unified-search-ellipsized-title-subline branch August 27, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: accessibility feature: search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants