Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of displayname and ellipsis status message #22317

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

georgehrke
Copy link
Member

Signed-off-by: Georg Ehrke developer@georgehrke.com

Before After
8C59817F-ADDD-4EE0-A5AD-D6A08911E4C0 BFBE6BA4-F93F-43A0-BC05-892BD76617DD

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a title attribute on the ellipsised text to show the full status on hover?

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a title attribute on the ellipsised text to show the full status on hover?

@georgehrke
Copy link
Member Author

georgehrke commented Aug 20, 2020

Maybe add a title attribute on the ellipsised text to show the full status on hover?

We are using the Actions component here, so this needs to be done upstream in nc/vue.

Nevermind, fixed here.

@jancborchardt
Copy link
Member

jancborchardt commented Aug 20, 2020

Maybe add a title attribute on the ellipsised text to show the full status on hover?

I wouldn’t do that, we shouldn’t have tooltips all over (e.g. we also removed them from the avatars in Mail as it made no sense). When one wants to check the full message, they can go to the "Set custom status" dialog – and it’s their status in the first place. :) @georgehrke otherwise it looks good!

@rullzer rullzer mentioned this pull request Aug 21, 2020
19 tasks
@georgehrke
Copy link
Member Author

let me rebase

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 21, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 21, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32170: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\MoveFromCacheTraitTest::testSearchQueryByTag
Failed asserting that 0 matches expected 3.

/drone/src/tests/lib/Files/Cache/CacheTest.php:363

mariadb10.4-php7.3

Show full log
There was 1 error:

1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSameUriSameIdForDifferentCalendarTypes
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:50
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php:153
/drone/src/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:916

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

acceptance-header

  • tests/acceptance/features/header.feature:31
Show full log
  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:31
    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                                                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
      Failed asserting that true is false.
    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@georgehrke
Copy link
Member Author

Failures unrelated, merging.

@georgehrke georgehrke merged commit e212862 into master Aug 21, 2020
@georgehrke georgehrke deleted the bugfix/noid/status_ellipsis branch August 21, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants