Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable17] Use the correct mountpoint to calculate #21774

Merged
merged 5 commits into from
Jul 9, 2020
Merged

[stable17] Use the correct mountpoint to calculate #21774

merged 5 commits into from
Jul 9, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #21489

@rullzer @backportbot
Use the correct mountpoint to calculate
d587d5f 
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 17.0.8 milestone Jul 9, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Jul 9, 2020
danxuliu
danxuliu requested changes Jul 9, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration tests need to be adjusted for stable17, as they use an undefined step. I will take care of it later.

@rullzer rullzer mentioned this pull request Jul 9, 2020
Merged
1 task
danxuliu and others added 4 commits July 9, 2020 20:19
@danxuliu
Add more integration tests for resharing permissions
c47a641 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@icewind1991 @danxuliu
ensure mounts are scanned during tests
c341a4b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @danxuliu
ensure home storage is initialized on first setup
76e415a 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @danxuliu
better cleanup in share tests
50f49c2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
danxuliu
danxuliu approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, it was just a matter of removing the accepting last share steps, as they were introduced in Nextcloud 18.

@rullzer rullzer merged commit ab120cf into stable17 Jul 9, 2020
@rullzer rullzer deleted the backport/21489/stable17 branch July 9, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu danxuliu approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: sharing
Projects
None yet
Milestone
Nextcloud 17.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @danxuliu @icewind1991