Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #21285 as oneliner #21499

Merged
merged 2 commits into from
Jul 8, 2020
Merged

fix #21285 as oneliner #21499

merged 2 commits into from
Jul 8, 2020

Commits on Jun 20, 2020

  1. Return correct loginname in credentials, 

    even when token is invalid or has no password.

Returning the uid as loginname is wrong, and leads to problems when
these differ. E.g. the getapppassword API was creating app token with
the uid as loginname. In a scenario with external authentication (such
as LDAP), these tokens were then invalidated next time their underlying
password was checked, and systematically ceased to function.

Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
    Lionel Elie Mamane committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    80973cd View commit details
    Browse the repository at this point in the history

  2. adapt testGetLoginCredentialsInvalidTokenLoginCredentials() unit test… 

    … to uid != loginname

Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
    Lionel Elie Mamane committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    c173602 View commit details
    Browse the repository at this point in the history