Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up auth tokens when user is deleted #21416

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Clean up auth tokens when user is deleted #21416

merged 1 commit into from
Jun 16, 2020

Conversation

ChristophWurst
Copy link
Member

Steps to test

  • Create a new user
  • Log in as that user
  • See a new row appear in oc_authtoken
  • Delete the user again

On master: the row persists.
Here: row vanishes with user.

@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jun 15, 2020
@ChristophWurst ChristophWurst self-assigned this Jun 15, 2020
@ChristophWurst
Copy link
Member Author

/backport to stable19

@ChristophWurst
Copy link
Member Author

/backport to stable18

rullzer
rullzer approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juliabode juliabode removed their request for review June 15, 2020 14:41
@ChristophWurst
Clean up auth tokens when user is deleted
3474afa 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst merged commit 5e52c11 into master Jun 16, 2020
@ChristophWurst ChristophWurst deleted the fix/user-deleted-token-cleanup branch June 16, 2020 08:01
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 16, 2020
Merged
@ChristophWurst
Copy link
Member Author

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@georgehrke georgehrke georgehrke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@Nutomic Nutomic Awaiting requested review from Nutomic

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@fabwu fabwu Awaiting requested review from fabwu

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug feature: authentication security
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @rullzer @georgehrke @MorrisJobke