Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling user provisioning for subadmins with many groups #20677

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Scaling user provisioning for subadmins with many groups #20677

merged 2 commits into from
Apr 30, 2020

Commits on Apr 25, 2020

  1. Patch to optimize for large installations (>5000 users >20000 groups)… 

    … where subadmins have access to many of groups (>250)

- UsersController:editUser() calls isUserAccessible() even if the user is admin

This fix reduces API calls to editUser (ex change locale/display name) from >2 minutes (!) to ~3 seconds per call in average.

Signed-off-by: Mikael Hammarin <mikael@try2.se>
    @mikaelh @nickvergessen
    mikaelh authored and nickvergessen committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    6ffde74 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Don't loop over all groups to check for subadmins 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    e24e9ec View commit details
    Browse the repository at this point in the history