Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAV's exception logger should deal with any Throwable #20503

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Apr 15, 2020

I was having an occasion where a TypeError was passed in via sabre's WildcardEmitterTrait

"Exception": "TypeError", "Message": "Argument 1 passed to OCA\\DAV\\Connector\\Sabre\\ExceptionLoggerPlugin::logException() must be an instance of Exception, instance of TypeError given, called in /srv/http/nextcloud/master/3rdparty/sabre/event/lib/WildcardEmitterTrait.php on line 89",

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

@blizzz
Copy link
Member Author

blizzz commented Apr 15, 2020

cs fixer complains about unrelated files, can be ignored in this context

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 15, 2020
@rullzer rullzer mentioned this pull request Apr 15, 2020
59 tasks
@blizzz blizzz merged commit 48a8f0a into master Apr 15, 2020
@blizzz blizzz deleted the fix/noid/dav-catch-throwable branch April 15, 2020 19:48
@rullzer rullzer mentioned this pull request Apr 15, 2020
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants