Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utf8 encoding everywhere #20403

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Use utf8 encoding everywhere #20403

merged 1 commit into from
Apr 10, 2020

Conversation

ChristophWurst
Copy link
Member

PSR2 likes that and so do I

@ChristophWurst
Use utf8 encoding everywhere
a0e94e6 
PSR2 likes that and so do I

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 19 milestone Apr 10, 2020
@ChristophWurst ChristophWurst self-assigned this Apr 10, 2020
ChristophWurst
ChristophWurst commented Apr 10, 2020
View reviewed changes
apps/settings/templates/settings/empty.php
@@ -21,4 +21,4 @@
*
*/

# used for Personal/Additional settings as fallback for legacy settings
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't even tell what changed here. might need to hexedit it 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, changed the EOF

@skjnldsv skjnldsv added 14-feedback and removed 3. to review Waiting for reviews labels Apr 10, 2020
@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 14-feedback labels Apr 10, 2020
@gary-kim
Copy link
Member

gary-kim commented Apr 10, 2020 •
edited
Loading

@skjnldsv I'm assuming you were trying to add 4. to release rather than 14-feedback? Otherwise, at least one of your customers really hates upgrading.

@skjnldsv
Copy link
Member

@skjnldsv I'm assuming you were trying to add 4. to release rather than 14-feedback? Otherwise, at least one of your customers really hates upgrading.

oups 🙈
Thanks for spotting this!

@ChristophWurst ChristophWurst merged commit edf8ce3 into master Apr 10, 2020
@ChristophWurst ChristophWurst deleted the techdebt/utf8-encoding branch April 10, 2020 12:05
@rullzer rullzer mentioned this pull request Apr 13, 2020
Merged
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @gary-kim @skjnldsv @rullzer