Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute redirect #20401

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Fix absolute redirect #20401

merged 1 commit into from
Apr 15, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 10, 2020

Fix #6822

It will just not work for url with like a hash in it.
Because we moved all of our apps to proper javascript url history, this should not be an issue anymore.

@skjnldsv skjnldsv self-assigned this Apr 10, 2020
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug labels Apr 10, 2020
@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Apr 10, 2020
@skjnldsv
Copy link
Member Author

/backport to stable18

@skjnldsv
Copy link
Member Author

/backport to stable17

@skjnldsv
Copy link
Member Author

/backport to stable16

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer merged commit 95ad9ab into master Apr 15, 2020
@rullzer rullzer deleted the fix/login-sso-redirct branch April 15, 2020 09:28
@backportbot-nextcloud
Copy link

backport to stable18 in #20495

@backportbot-nextcloud
Copy link

backport to stable17 in #20496

@backportbot-nextcloud
Copy link

backport to stable16 in #20497 with conflicts ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redirect_url seems to be double URL-decoded after login
3 participants