Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden seekable http stream a bit against failures #20385

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

icewind1991
Copy link
Member

Fixes #20378

@stjosh can you check if this fixes the problem for you

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 9, 2020
@icewind1991 icewind1991 added this to the Nextcloud 19 milestone Apr 9, 2020
@rullzer rullzer mentioned this pull request Apr 9, 2020
59 tasks
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@rullzer rullzer merged commit fb64fda into master Apr 10, 2020
@rullzer rullzer deleted the skeeable-http-harden branch April 10, 2020 06:34
@stjosh
Copy link

stjosh commented Apr 10, 2020

Perfect, many thanks for the quick fix! 👌🏻

@MorrisJobke
Copy link
Member

backport to stable18 is in #20965

@MorrisJobke
Copy link
Member

backport to stable17 is in #20966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feof error in SeekableHttpStream.php
6 participants