use https by default if no protocol is given. #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction if it is explicitely given Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
|
@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @PVince81 and @nickvergessen to be potential reviewers. |
|
I guess it's okay, although it will trap some users in the beginning. 👍 |
|
LGTM. But we should really look into #1667 since the messages here are not really understandable for the avarage user. But good security hardening! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we always used a http connection as fall-back if https falied which is not perfect from a security point of view.
This pr changes the behaviour to always use https. Only excption: if http is explicitly given (
user@http://server.org). Existing shares continue to work because we always store the protocol as part of the server url in the share table.cc @LukasReschke we already discussed this in the past