Use file path for direct editing #18224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Either that or you add backend logic to iterate over all the files you get back. To determine if we have edit permissions |
This seems to be the cleaner approach to me, so we actually hand over the correct file that was selected by the user to the editor. Iterating is what collabora does but will break as soon as the app also wants to check for share permissions for example. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/direct-editing-path
branch
from
38f9292
to
e29a76b
Compare
|
Rebased and squashed again |
rullzer
approved these changes
Dec 5, 2019
|
Can we get this in soon? (As Julius is on vacation until Monday). |
ChristophWurst
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue with using the file id is that we cannot determine the correct permissions if the first file is picked. Therefore the direct editing API should always use the path for the current user.
Sorry for coming up with this so late, this was just reported by OnlyOffice implementing the API and I didn't have it on my radar since Collabora only works with file ids.