-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharee API GS fixes #18144
Sharee API GS fixes #18144
Conversation
e8becfd
to
6c27b5a
Compare
@rullzer I did the front, but there is one thing that was used that is not compliant to your new config:
|
right. Let me fix that. Thanks for the work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
ff21cdd
to
49f4e3d
Compare
Rebased |
@rullzer one more test to make sure everything is how you wanted? |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
49f4e3d
to
9b82225
Compare
Fixed the tests. @skjnldsv it does what it should do it hink. What I find weird is that when you press search globally that the dropdown vanishes and you don't get proper feedback 'no results found' or something. But lets get this in and fix that later.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
We should backport the functinality to 17 and 16 (maybe even 15) but will require manual work. |
No description provided.