new Group-Member association attribute (zimbraMailForwardingAddress) #16737

tofuSCHNITZEL · 2019-08-13T21:38:12Z

added "zimbraMailForwardingAddress" as a Group-Member association attribute to enable the use of Zimbra Distribution Lists as groups in nextcloud when connecting to a zimbra LDAP

skjnldsv · 2019-09-28T15:23:05Z

Bump :)

blizzz · 2019-10-11T15:55:12Z

the group backend is already quite complex and this is growing more with this addition. That is, I have nothing against it per se, but it would be cool if we could split it up a bit. So, for instance all the association-attriubte-specific code could go into specialized classes, adaptor like. And we just load whatever we need. We can have smaller units with less conditions and code paths. Easier to test and understand.

tofuSCHNITZEL · 2019-10-17T15:24:15Z

So, for instance all the association-attriubte-specific code could go into specialized classes, adaptor like.

this is unfortunately beyond the scope of my time and abilities.
but if someone could start the refactor I could implement this feature with the new pattern. (because then I have reference on how it should be organised)

tofuSCHNITZEL · 2020-05-04T22:38:18Z

sorry I didnt get notified about the potential merge into 18beta. I updated the branch to be up to date with the master.. any chance for v19?

blizzz · 2020-05-05T13:36:46Z

sorry I didnt get notified about the potential merge into 18beta. I updated the branch to be up to date with the master.. any chance for v19?

We're now in Beta, which essentially also is a feature freeze. 20 then.

blizzz · 2020-06-16T22:24:30Z

Tests are failing. Perhaps related to the submodule changes? Please take them out.

tofuSCHNITZEL · 2020-06-16T22:37:04Z

Tests are failing. Perhaps related to the submodule changes? Please take them out.

I think I fixed it somehow.

blizzz

by catch, looks good otherwise. Only, please sign your commits https://github.com/nextcloud/server/pull/16737/checks?check_run_id=778568009 :)

apps/user_ldap/lib/Group_LDAP.php

tofuSCHNITZEL · 2020-06-25T08:22:25Z

sorry, I missed the sign-off on some older commits... I tried the suggested rebase command but it just blows everything up - not beeing able to resolve conflicts in files I never touched... Is it acceptable if they stay unsigned? or could you help me with the rebase?

MorrisJobke · 2020-07-06T10:22:46Z

sorry, I missed the sign-off on some older commits... I tried the suggested rebase command but it just blows everything up - not beeing able to resolve conflicts in files I never touched... Is it acceptable if they stay unsigned? or could you help me with the rebase?

That was due to the merge commits. I rebased the whole branch here and squashed everything into one commit. I also resolved some issues that arose from the updated code in the master branch. I noticed that you deleted one block during one of your merges of master. I added it here again. If this is not needed anymore we could delete it again.

Beside that all your commits already contained the sign-off messages.

MorrisJobke · 2020-07-06T10:23:17Z

apps/user_ldap/lib/Group_LDAP.php

+			// DNs are returned as keys; this is probably only the case if
+			// nested groups are used and/or group member attributes are DNs
+		}
+


This whole block went missing by one of the merges from master. I don't know if this was intentional or not.

hm I have no idea why or when this was removed... it was still present in 18.0.4. unfortunately I cant really test since this is only called when non LDAP backend is used (and I dont have a test setup for that) also I'm not even sure when the inGroup function is called....

IIRC it was a bugfix: 1d48c03#diff-994e1d45c127dc64e57744e2bf2eff3d

MorrisJobke · 2020-07-06T10:23:52Z

Please give this a good try and then it is ready for merge IMO.

MorrisJobke · 2020-07-06T12:01:26Z

Conflicts because of recently merged #21171 ... let me rebase again :)

tofuSCHNITZEL · 2020-07-06T12:17:41Z

Please give this a good try and then it is ready for merge IMO.

my local test install seems fine.

MorrisJobke

Code looks good 👍

MorrisJobke · 2020-07-06T21:22:25Z

I also fixed the code style and this is now ready to go in.

MorrisJobke · 2020-07-07T08:09:54Z

LDAP integration tests don't like it. @blizzz to the rescue

blizzz · 2020-08-07T11:43:27Z

LDAP integration tests don't like it. @blizzz to the rescue

It seems it is just "Notice: Undefined index: label in /drone/src/build/integration/features/bootstrap/Sharing.php line 740"? Let me rebase once more.

MorrisJobke · 2020-08-07T14:56:26Z

LDAP integration tests don't like it. @blizzz to the rescue

There are still some that fail.

blizzz · 2020-08-07T21:29:16Z

now they are running through :) It was the block as mentioned ^ let me squash, then merge

…ribute to enable the use of Zimbra Distribution Lists as groups in nextcloud when connecting to a zimbra LDAP Signed-off-by: Tobias Perschon <tobias@perschon.at> fix cs:check Signed-off-by: Tobias Perschon <tobias@perschon.at> Update apps/user_ldap/lib/Group_LDAP.php Co-authored-by: blizzz <blizzz@arthur-schiwon.de> Signed-off-by: Tobias Perschon <tobias@perschon.at>

welcome · 2020-08-07T22:20:53Z

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

tofuSCHNITZEL · 2020-08-08T09:05:04Z

Thanks for all your help!

tofuSCHNITZEL force-pushed the feature-zimbraldap branch from b6469a3 to ab9d608 Compare August 13, 2019 21:38

tofuSCHNITZEL mentioned this pull request Aug 13, 2019

new Group-Member association attribute (zimbraMailForwardingAddress) #14767

Closed

georgehrke requested a review from blizzz August 14, 2019 07:41

skjnldsv added 3. to review Waiting for reviews feature: ldap labels Sep 28, 2019

skjnldsv added this to the Nextcloud 18 milestone Sep 28, 2019

This was referenced Dec 11, 2019

18 Beta 2 #18343

Merged

18 beta 3 #18370

Merged

blizzz added the enhancement label Dec 13, 2019

rullzer mentioned this pull request Dec 19, 2019

18 beta 4 #18480

Merged

18 tasks

rullzer removed this from the Nextcloud 18 milestone Dec 23, 2019

tofuSCHNITZEL force-pushed the feature-zimbraldap branch from 7a95e31 to 3df0374 Compare May 4, 2020 21:52

blizzz added this to the Nextcloud 20 milestone May 5, 2020

tofuSCHNITZEL force-pushed the feature-zimbraldap branch 2 times, most recently from 98888bc to b64a0c7 Compare June 16, 2020 23:59

blizzz approved these changes Jun 24, 2020

View reviewed changes

apps/user_ldap/lib/Group_LDAP.php Outdated Show resolved Hide resolved

tofuSCHNITZEL force-pushed the feature-zimbraldap branch from 0c44f66 to de7a918 Compare June 25, 2020 07:53

MorrisJobke force-pushed the feature-zimbraldap branch from de7a918 to bd37b4c Compare July 6, 2020 10:21

MorrisJobke reviewed Jul 6, 2020

View reviewed changes

MorrisJobke force-pushed the feature-zimbraldap branch from bd37b4c to de799e6 Compare July 6, 2020 12:03

MorrisJobke approved these changes Jul 6, 2020

View reviewed changes

MorrisJobke force-pushed the feature-zimbraldap branch from de799e6 to aee36c4 Compare July 6, 2020 21:22

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 6, 2020

MorrisJobke mentioned this pull request Jul 6, 2020

shortcut in reading nested group members when IN_CHAIN is available #21559

Merged

MorrisJobke force-pushed the feature-zimbraldap branch from aee36c4 to b583b61 Compare July 7, 2020 07:39

blizzz force-pushed the feature-zimbraldap branch from b583b61 to ad31493 Compare August 7, 2020 14:04

blizzz force-pushed the feature-zimbraldap branch from 42cbe26 to 551d904 Compare August 7, 2020 21:31

blizzz merged commit 579c707 into nextcloud:master Aug 7, 2020

blizzz mentioned this pull request Aug 10, 2020

use break not continue in switch to avoid warning #22175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new Group-Member association attribute (zimbraMailForwardingAddress) #16737

new Group-Member association attribute (zimbraMailForwardingAddress) #16737

tofuSCHNITZEL commented Aug 13, 2019

skjnldsv commented Sep 28, 2019

blizzz commented Oct 11, 2019

tofuSCHNITZEL commented Oct 17, 2019

tofuSCHNITZEL commented May 4, 2020

blizzz commented May 5, 2020

blizzz commented Jun 16, 2020

tofuSCHNITZEL commented Jun 16, 2020 •

edited

Loading

blizzz left a comment

tofuSCHNITZEL commented Jun 25, 2020

MorrisJobke commented Jul 6, 2020

MorrisJobke Jul 6, 2020

tofuSCHNITZEL Jul 6, 2020

blizzz Aug 7, 2020 •

edited

Loading

MorrisJobke commented Jul 6, 2020

MorrisJobke commented Jul 6, 2020

tofuSCHNITZEL commented Jul 6, 2020

MorrisJobke left a comment

MorrisJobke commented Jul 6, 2020

MorrisJobke commented Jul 7, 2020

blizzz commented Aug 7, 2020

MorrisJobke commented Aug 7, 2020

blizzz commented Aug 7, 2020 •

edited

Loading

welcome bot commented Aug 7, 2020

tofuSCHNITZEL commented Aug 8, 2020

new Group-Member association attribute (zimbraMailForwardingAddress) #16737

new Group-Member association attribute (zimbraMailForwardingAddress) #16737

Conversation

tofuSCHNITZEL commented Aug 13, 2019

skjnldsv commented Sep 28, 2019

blizzz commented Oct 11, 2019

tofuSCHNITZEL commented Oct 17, 2019

tofuSCHNITZEL commented May 4, 2020

blizzz commented May 5, 2020

blizzz commented Jun 16, 2020

tofuSCHNITZEL commented Jun 16, 2020 • edited Loading

blizzz left a comment

Choose a reason for hiding this comment

tofuSCHNITZEL commented Jun 25, 2020

MorrisJobke commented Jul 6, 2020

MorrisJobke Jul 6, 2020

Choose a reason for hiding this comment

tofuSCHNITZEL Jul 6, 2020

Choose a reason for hiding this comment

blizzz Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

MorrisJobke commented Jul 6, 2020

MorrisJobke commented Jul 6, 2020

tofuSCHNITZEL commented Jul 6, 2020

MorrisJobke left a comment

Choose a reason for hiding this comment

MorrisJobke commented Jul 6, 2020

MorrisJobke commented Jul 7, 2020

blizzz commented Aug 7, 2020

MorrisJobke commented Aug 7, 2020

blizzz commented Aug 7, 2020 • edited Loading

welcome bot commented Aug 7, 2020

tofuSCHNITZEL commented Aug 8, 2020

tofuSCHNITZEL commented Jun 16, 2020 •

edited

Loading

blizzz Aug 7, 2020 •

edited

Loading

blizzz commented Aug 7, 2020 •

edited

Loading