Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests and composer dir from coverage #1624

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Oct 5, 2016

No need to cover tests dirs or the composer files.

CC: @LukasReschke @nickvergessen @MorrisJobke

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Oct 5, 2016
@rullzer rullzer added this to the Nextcloud 11.0 milestone Oct 5, 2016
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @butonic and @PVince81 to be potential reviewers.

@nickvergessen
Copy link
Member

yay 👍

@LukasReschke
Copy link
Member

LGTM

@LukasReschke LukasReschke merged commit 815616f into master Oct 5, 2016
@LukasReschke LukasReschke deleted the exclude_coverage_dirs branch October 5, 2016 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants