Add icons to activity navigation #1622
Conversation
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @schiessle and @skjnldsv to be potential reviewers. |
|
Please always @-mention the @nextcloud/designers team directly :) From my view it looks good! 👍 |
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="22" width="22"><path d="M11.017.06l2.946 7.384L22 8.077l-6.11 5.082L17.77 21l-6.72-4.242-6.876 4.213 1.957-7.703L0 8.03l7.932-.52z" color="#000"/></svg> | |||
There was a problem hiding this comment.
Not a big deal, but you don't need to set the fill value since black is the default (see svgo optimization) 😁
0.196 KiB - 1% = 0.194 KiB
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="32" width="32"><path d="M2.917 5.015c-.5 0-.92.42-.92.92v22.16c0 .516.402.92.92.92h26.157a.91.91 0 0 0 .92-.92V9.938c0-.5-.418-.926-.92-.926H15.997l-4-4z" fill-rule="evenodd" fill="#000"/></svg> | |||
There was a problem hiding this comment.
Same here, we can gain a few KB 😊
0.237 KiB - 5.3% = 0.225 KiB
There was a problem hiding this comment.
👍 perfect!
I know this is not the most important thing to do for a few KB, but since we're at it, doesn't cost us more to optimize! :)
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
activity-sidebar-icons
branch
from
6afdf06
to
671f16f
Compare
Current coverage is 30.61% (diff: 0.00%)@@ master #1622 diff @@
==========================================
Files 1081 1081
Lines 60019 60023 +4
Methods 6808 6808
Messages 0 0
Branches 0 0
==========================================
Hits 18378 18378
- Misses 41641 41645 +4
Partials 0 0
|
|
👍 |
Not yet |
Related to nextcloud/activity#48
@jancborchardt @raghunayyar @skjnldsv