Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateState is empty if no update is available #1554

Merged
merged 1 commit into from
Sep 28, 2016

Conversation

LukasReschke
Copy link
Member

This leads to log messages such as "Undefined index: updaterEnabled at /media/psf/nextcloud/apps/updatenotification/lib/Controller/AdminController.php#116".

cc @nickvergessen as discussed

@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Sep 28, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Sep 28, 2016
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @blizzz and @MorrisJobke to be potential reviewers

@nickvergessen
Copy link
Member

👍

This leads to log messages such as "Undefined index: updaterEnabled at /media/psf/nextcloud/apps/updatenotification/lib/Controller/AdminController.php#116".

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@MorrisJobke
Copy link
Member

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2016
@LukasReschke LukasReschke merged commit 32640c9 into master Sep 28, 2016
@LukasReschke LukasReschke deleted the updatestate-can-be-empty branch September 28, 2016 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants