Refactor complex LoginController logic into a login chain of responsibility #15365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
3. to review
ChristophWurst
force-pushed
the
refactor/login-chain
branch
from
f782905
to
17d6864
Compare
ChristophWurst
force-pushed
the
refactor/login-chain
branch
from
17d6864
to
c868ce2
Compare
|
From what I can tell CI failures do not look related. But tell me if I'm wrong. |
-> restarted |
rullzer
approved these changes
May 7, 2019
ChristophWurst
commented
May 7, 2019
| } | ||
|
|
||
| public function testNotTwoFactorAuthenticated() { | ||
| $this->fail('todo'); |
There was a problem hiding this comment.
guess what … CI fails for a reason
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
refactor/login-chain
branch
from
c868ce2
to
170582d
Compare
MorrisJobke
added
4. to release
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been on my list of code to refactor for a long time. As I now have to touch it for https://github.com/orgs/nextcloud/projects/29, I decided to break the code into smaller, maintainable and testable chunks. The code now follows a more strict single responsibility principle, while implementing the chain of responsibility pattern.