trust private non-experimental apps

[andreas-p]

Referencing #561

Using the key 'trusted', an apps directory configured using apps_paths in config.php can be marked as non-experimental and trusted, despite not being listed in apps repositories.
All apps in the marked directory get an $app['level'] of 50, which is displayed as "private trusted" in the apps app, and won't get disabled when upgrading.

[MorrisJobke]

Mmmh ... yet another config switch ... I guess the proper way of doing this is to try to enable apps after the upgrade. On the other side it would be nice to not have the red label in the apps management.

[LukasReschke]

Not a fan of this, the new app store with 11 will anyways kinda drop this notation since all apps are signed by default. (basically there's then a "normal" and an "official" app, local apps would simply count as normal then)

👎 from me on this one thus.

[andreas-p]

On a production system, you won't like your apps being disabled. You might lose the group specific enabling, and scanning all disabled apps that might need reenabling is a PITA.
This flag basically declares the directory as local repository, making apps behave just like official apps.

[MorrisJobke]

This flag basically declares the directory as local repository, making apps behave just like official apps.

Then this is bypassing a safety check. We try to enhance the updater for 11 anyways to not leave all non-official apps disabled, but rather try to enable them afterwards.

[andreas-p]

@LukasReschke , how do you propose to deal with #561 ?

[LukasReschke]

@LukasReschke , how do you propose to deal with #561 ?

Basically what @MorrisJobke said in #1527 (comment), we should improve the updater instead of adding code that will barely be used and tested.

[andreas-p]

So you'd like experimental apps re-enabled as well?
What about marking apps non-experimental?

[LukasReschke]

What about marking apps non-experimental?

In Nextcloud 11 local apps won't be marked as experimental or anything. They won't have any label at all.

[andreas-p]

If re-enabling apps after upgrading (this includes appstore apps as well) respects previous enabling for specific groups that would be ok.

[MorrisJobke]

If re-enabling apps after upgrading (this includes appstore apps as well) respects previous enabling for specific groups that would be ok.

Of course. The app should be in the same state as before.

[nickvergessen]

Yeah let's do that. Sounds much more sane.