[stable15] Fix plural rule detection for languages #14867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
ChristophWurst and
skjnldsv
ChristophWurst
approved these changes
Mar 26, 2019
skjnldsv
approved these changes
Mar 26, 2019
ChristophWurst
added
4. to release
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
* undefined and empty string should trigger the default plural form Signed-off-by: Morris Jobke <hey@morrisjobke.de>
rullzer
force-pushed
the
backport/14628/stable15
branch
from
917e2cb
to
7b23324
Compare
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17372: failureTESTS=acceptance, TESTS-ACCEPTANCE=app-comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14628
15 didn't had any compiled assets for l10n.js, right?