Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable15] Make regions translatable #14859

Merged
merged 1 commit into from
Mar 26, 2019
Merged

[stable15] Make regions translatable #14859

merged 1 commit into from
Mar 26, 2019

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #14853

@MorrisJobke
Make regions translatable
5015459 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 15.0.6 milestone Mar 26, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 26, 2019
Merged
ChristophWurst
ChristophWurst approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 26, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 26, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17316: failure

ENABLE_REDIS=true, TESTS=nodb-codecov

Show full log 
There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=true, PHP=7.0

Show full log 
There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=true, PHP=7.1

Show full log 
There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=false, PHP=7.2

Show full log 
There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=false, PHP=7.3

Show full log 
There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

TESTS=litmus-v2

  • git clone failure - can typically be ignored

@MorrisJobke MorrisJobke merged commit c7a1e6c into stable15 Mar 26, 2019
@MorrisJobke MorrisJobke deleted the backport/14853/stable15 branch March 26, 2019 16:45
@rullzer rullzer mentioned this pull request Mar 29, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 15.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @ChristophWurst