-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation go.php to 15 and adjusted copyright year. #14716
Updated documentation go.php to 15 and adjusted copyright year. #14716
Conversation
Signed-off-by: Thomas Pulzer <t.pulzer@thesecretgamer.de>
8b20f30
to
7233c0e
Compare
Only if someone uses "example" as theme 😎 |
#11304 we had some discussions about this (see the resolved conversation). I think we should go for |
Dynamic resolving would be definitely better. 😃 Of course, if the version number can be resolved dynamically, than that's the better approach. Is this just legacy remains or is there a reason that anything in the affected file is hardcoded respectively has no dependency on any other file? |
This file is not used anywhere. It's an example for a custom theme. |
Ah, I see. |
It seems, the LDAP plugin does not use any curious method but the buildDocLinkToKey function in the legacy/defaults file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for 15 IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me 👍
/backport to master |
The backport to master failed. Please do this backport manually. |
Fixed on master already |
Updated stable version
Fixes #14650