-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable15] groupname like username - allow share with both #14709
Conversation
Signed-off-by: Christian Aigner <christian.aigner@huemer-it.com>
/backport to master |
Usually we first develop something against master and then backport to the stable branches. But for this one it's okay to do it the other way around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
fixed tabulator Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
tabulator change Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense and works 👍
Status of 17173: failureTESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing
TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link
|
backport to master in #14766 |
It happens that users and groups have the same name in big organizations, the nextcloud standard behaviour is like this: I can only share with the user or the group.
With this small extension it's possible to share files with the group "test" and the user "test" at the same time.
I added this feature, because it makes no sense to me to disallow the sharing because of the same name of a group and an user.