-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable15] Add activities for group membership changes #14534
Merged
MorrisJobke
merged 3 commits into
stable15
from
backport/14502/add-activities-for-group-membership-changes
Mar 8, 2019
Merged
[stable15] Add activities for group membership changes #14534
MorrisJobke
merged 3 commits into
stable15
from
backport/14502/add-activities-for-group-membership-changes
Mar 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
enhancement
3. to review
Waiting for reviews
feature: users and groups
feature: activity and notification
labels
Mar 5, 2019
skjnldsv
approved these changes
Mar 5, 2019
MorrisJobke
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Mar 5, 2019
CI failures |
Fixed |
Still some of them fail 🙈 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
backport/14502/add-activities-for-group-membership-changes
branch
from
March 7, 2019 09:04
3ef6582
to
fee02bb
Compare
arg, Fixed |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 16842: failureTESTS=acceptance, TESTS-ACCEPTANCE=app-files
Show full log
|
MorrisJobke
deleted the
backport/14502/add-activities-for-group-membership-changes
branch
March 8, 2019 09:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
enhancement
feature: activity and notification
feature: users and groups
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #14502