Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #13319: load oc-backbone-webdav before loading versions app #14472

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix for issue #13319: load oc-backbone-webdav before loading versions app #14472

merged 1 commit into from
Mar 4, 2019

Conversation

felixn
Copy link

@felixn felixn commented Mar 2, 2019

See issue #13319

Fix for issue #13319: load oc-backbone-webdav before loading versions…
b0c0bf8 
… app

Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
@felixn felixn added bug 3. to review Waiting for reviews labels Mar 2, 2019
@felixn
Copy link
Author

felixn commented Mar 2, 2019

Inspired by the comments app:

server/apps/comments/lib/AppInfo/Application.php

Lines 64 to 65 in b0c0bf8

Util::addScript('oc-backbone-webdav');
Util::addScript('comments', 'merged');

rullzer
rullzer approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point!

@rullzer rullzer added this to the Nextcloud 15.0.6 milestone Mar 4, 2019
ChristophWurst
ChristophWurst approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@rullzer rullzer merged commit 4ee9069 into nextcloud:stable15 Mar 4, 2019
@felixn felixn deleted the stable15 branch March 4, 2019 11:20
@ChristophWurst
Copy link
Member

@rullzer backport?

@rullzer
Copy link
Member

rullzer commented Mar 4, 2019

I think this only affects 15.
In 16 this si alays bundled. And before 15 doesn't use the webdav yet I think

@juliusknorr juliusknorr mentioned this pull request Mar 4, 2019
Closed
@juliusknorr
Copy link
Member

Yes, just tested and works fine with 16.

@rullzer rullzer mentioned this pull request Mar 29, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 15.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@felixn @ChristophWurst @rullzer @juliusknorr @MorrisJobke