Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/14307/expire date change eventhandler #14390

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

juliusknorr
Copy link
Member

Fixes #14307

There was already an event registered to be triggered on change

'change .datepicker': 'onChangeExpirationDate',

but the actual implementation was missing.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2019
@MorrisJobke
Copy link
Member

@juliushaertl Mind to fix the conflicts?

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/14307/expire-date-change-eventhandler branch from d7e05c8 to 44979f9 Compare February 27, 2019 14:12
@rullzer rullzer merged commit 90f695f into master Feb 27, 2019
@rullzer rullzer deleted the bugfix/14307/expire-date-change-eventhandler branch February 27, 2019 21:24
@MorrisJobke
Copy link
Member

/backport to stable15

@backportbot-nextcloud

This comment has been minimized.

@MorrisJobke
Copy link
Member

/backport to stable14

@MorrisJobke
Copy link
Member

@juliushaertl Mind to open backport PRs?

@backportbot-nextcloud

This comment has been minimized.

@juliusknorr
Copy link
Member Author

stable14: #14504
stable15: #14503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants