-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/14307/expire date change eventhandler #14390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
skjnldsv,
MorrisJobke,
ChristophWurst and
danxuliu
February 26, 2019 18:32
skjnldsv
approved these changes
Feb 26, 2019
MorrisJobke
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Feb 27, 2019
@juliushaertl Mind to fix the conflicts? |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/14307/expire-date-change-eventhandler
branch
from
February 27, 2019 14:12
d7e05c8
to
44979f9
Compare
/backport to stable15 |
This comment has been minimized.
This comment has been minimized.
/backport to stable14 |
@juliushaertl Mind to open backport PRs? |
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14307
There was already an event registered to be triggered on change
server/core/js/sharedialoglinkshareview.js
Line 70 in d7e05c8
but the actual implementation was missing.