-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ocm end-point discovery discovery #14255
Conversation
TODO:
|
@rullzer updated the documentation as well: nextcloud/documentation#1260 |
@MorrisJobke just editing it there is enough to also trigger the recreation of htacceess during update right? |
Please add a setup check to the admin settings to notify users about this. See for example the well-known check in the browser that does something like this: Line 251 in 813ff43
|
It is written on every update - so yes. |
@MorrisJobke seems like we don't have a similar check for the "ocs-provider" endpoint as well. I'm not sure how to add this quickly. Maybe some of our @nextcloud/javascript experts? |
I added a check for both (while I'm on it), the ocs-provider and the ocm-provider route, see the last two commits |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
…ected to the index.php Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
And let me also rebase to resolve conflicts ... |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@MorrisJobke thanks for taking care of it! 👍 |
And let me add some unit tests for it. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
b980890
to
faef057
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
/backport to stable15 |
The backport to stable15 failed. Please do this backport manually. |
Backport in #14312 |
@schiessle Is there any reason why this is not put under the |
fix #14247