Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Make sure to always load the latest icons-vars.css file #12739

Merged
merged 1 commit into from
Dec 8, 2018
Merged

[stable14] Make sure to always load the latest icons-vars.css file #12739

merged 1 commit into from
Dec 8, 2018

Conversation

juliusknorr
Copy link
Member

Backport of #12408

The icons-vars.css file was taken from browser cache even it was changed.

Steps to reproduce:

  1. run occ maintenance:repair to clear the css cache
  2. Load the files app
  3. Load a different app that uses the scss icons methods (like deck on master)

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Nov 29, 2018
@juliusknorr juliusknorr added this to the Nextcloud 14.0.5 milestone Nov 29, 2018
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 29, 2018
@MorrisJobke
Copy link
Member

Restarted CI

@MorrisJobke
Copy link
Member

https://drone.nextcloud.com/nextcloud/server/13185

@MorrisJobke
Copy link
Member

There are far too many failures in the tests. @juliushaertl Mind to have a look at them?

@juliusknorr juliusknorr added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 4, 2018
@juliusknorr
Make sure to always load the latest icons-vars.css file
72ab9ed 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 7, 2018
@juliusknorr
Copy link
Member Author

Fixed.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2018

Failure unrelated! :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 8, 2018
@skjnldsv skjnldsv merged commit cabded0 into stable14 Dec 8, 2018
@skjnldsv skjnldsv deleted the stable14-12408 branch December 8, 2018 10:13
@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 14.0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @MorrisJobke @skjnldsv @weeman1337 @ChristophWurst