Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es6-shim as polyfill and minify core vendor scripts #12317

Merged
merged 2 commits into from
Nov 7, 2018

Conversation

juliusknorr
Copy link
Member

As discussed in #12083 (comment) this PR adds es6-shim to provide proper ES6 polyfills for IE11.

Fixes #12007

  • Replace es6-promises with es6-shim
  • Use minified version of underscore.js

@juliusknorr juliusknorr requested review from ChristophWurst, MorrisJobke and skjnldsv and removed request for ChristophWurst November 6, 2018 17:15
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes from me! :)

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

@juliusknorr
Copy link
Member Author

I'll look into the failing tests.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

jsunit test fixed, remaining acceptance test failures seem unrelated.

@MorrisJobke MorrisJobke merged commit 9eb5ab9 into master Nov 7, 2018
@MorrisJobke MorrisJobke deleted the deps/noid/es6-polyfill branch November 7, 2018 15:03
@MorrisJobke MorrisJobke mentioned this pull request Nov 7, 2018
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants