Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove app specific IUserTools and consolidate test #12150

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Oct 30, 2018

Just some house keeping. IUserTools with used in even older days for easier creation of Access instances…

Consolidation in the manager test looks bigger, essentially no changes. A data provider added, thus duplicate code removed, and using class members and setUp() instead of local variables, saves also duplication.

Just some house keeping. IUserTools with used in even older days for
easier creation of Access instances…

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLeanup! I LIKE IT. 🎸

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit d842cd1 into master Nov 1, 2018
@MorrisJobke MorrisJobke deleted the techdebt/noid/ldap-rm-iusertools branch November 1, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants