-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method #11968
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't mix such changes. Let's just adjust the verbosity output logic in this PR.
} | ||
$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function($path) use ($output) { | ||
$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) { | ||
$output->writeln("\tFile\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't change these unrelated commands. It's fine to fix/enhance this in another PR though.
}); | ||
|
||
$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) { | ||
$output->writeln("\tFolder\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
|
||
$output->writeln("\nScanning AppData for files"); | ||
$output->writeln('Scanning AppData for files'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
@@ -213,7 +178,6 @@ public function exceptionErrorHandler($severity, $message, $file, $line) { | |||
protected function presentStats(OutputInterface $output) { | |||
// Stop the timer | |||
$this->execTime += microtime(true); | |||
$output->writeln(""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the command logic (post increment, output formatting) in this PR 😉
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Let's close this one in favor of #11831 |
I just realized that it is for a different command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍 Code looks good
Follow-up #11831
This pr replace
if ($verbose)
withOutputInterface::VERBOSITY_VERBOSE