Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a more specific error message if config file is not writable #11663

Closed
wants to merge 6 commits into from
Closed

Show a more specific error message if config file is not writable #11663

wants to merge 6 commits into from

Commits on Oct 7, 2018

  1. Check if the config file is writable and throw an exception if it's not 

    Signed-off-by: Bernd Stellwag <burned@zerties.org>
    @burned42
    burned42 committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    e44ff03 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. If there are exceptions thrown, display an error page 

    OC_Util::getInstanceId() does try to set a new value if currently there
is no instance id set. This could lead to an exception if the config
file is not writable.

Signed-off-by: Bernd Stellwag <burned@zerties.org>
    @burned42
    burned42 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    7b7d9fe View commit details
    Browse the repository at this point in the history

  2. It's also ok if config dir is not writable but config file itself is 

    Signed-off-by: Bernd Stellwag <burned@zerties.org>
    @burned42
    burned42 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    ac1d3e6 View commit details
    Browse the repository at this point in the history

  3. Make sure creating a new config file works if the config dir is writable 

    Signed-off-by: Bernd Stellwag <burned@zerties.org>
    @burned42
    burned42 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    845cce5 View commit details
    Browse the repository at this point in the history

  4. Check if file modes got applied before proceeding with the test 

    Signed-off-by: Bernd Stellwag <burned@zerties.org>
    @burned42
    burned42 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    60c1fd1 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Merge branch 'master' into show_error_if_config_not_writable

    @burned42
    burned42 committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    59fac23 View commit details
    Browse the repository at this point in the history