Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header overflow, fix more apps menu, fix #11552 #11553

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix header overflow, fix more apps menu, fix #11552 #11553

merged 1 commit into from
Oct 2, 2018

Conversation

jancborchardt
Copy link
Member

Fix #11552, please review @nextcloud/designers :)

@jancborchardt
Fix header overflow, fix more apps menu, fix #11552
2665965 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews regression labels Oct 2, 2018
@jancborchardt jancborchardt added this to the Nextcloud 15 milestone Oct 2, 2018
@jancborchardt jancborchardt mentioned this pull request Oct 2, 2018
Closed
@weeman1337 weeman1337 self-requested a review October 2, 2018 18:33
MorrisJobke
MorrisJobke approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

weeman1337
weeman1337 approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more apps menu is working with these changes ✓

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 2, 2018
@jancborchardt jancborchardt mentioned this pull request Oct 2, 2018
Merged
@jancborchardt
Copy link
Member Author

Backport at #11558 because the breaking change was also backported. 😁

@MorrisJobke MorrisJobke merged commit 34751e0 into master Oct 2, 2018
@MorrisJobke MorrisJobke deleted the header-overflow branch October 2, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@weeman1337 weeman1337 weeman1337 approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. regression
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
3 participants
@jancborchardt @MorrisJobke @weeman1337