Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Fix invalid inline input confirm border #11426

Merged
merged 1 commit into from
Sep 28, 2018
Merged

[stable14] Fix invalid inline input confirm border #11426

merged 1 commit into from
Sep 28, 2018

Conversation

skjnldsv
Copy link
Member

Backport Fix invalid inline input confirm border #11423
@nextcloud/designers

@skjnldsv
Fix invalid inline input confirm border
79f1650 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Sep 28, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14.0.2 milestone Sep 28, 2018
@skjnldsv skjnldsv self-assigned this Sep 28, 2018
@skjnldsv skjnldsv changed the title Fix invalid inline input confirm border [stable14] Fix invalid inline input confirm border Sep 28, 2018
danxuliu
danxuliu approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (with an ad hoc form, not with the Contacts app as shown in the screenshot in the original pull request) and works 👍

@MorrisJobke MorrisJobke merged commit a646dba into stable14 Sep 28, 2018
@MorrisJobke MorrisJobke deleted the stable14-inline-input-error-fix branch October 1, 2018 09:04
@MorrisJobke MorrisJobke mentioned this pull request Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@danxuliu danxuliu danxuliu approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 14.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @danxuliu