[stable14] use a dummy database name for the default postgres database name #11421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the docker image does not setup the permissions correctly, by using a different name the nextcloud installer will create the database instead with the correct permissions Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
requested review from
MorrisJobke,
icewind1991,
ChristophWurst and
danxuliu
rullzer
changed the title
danxuliu
reviewed
Sep 28, 2018
| @@ -284,7 +284,7 @@ pipeline: | |||
| image: nextcloudci/php7.1:php7.1-16 | |||
| commands: | |||
| - sleep 10 # gives the database enough time to initialize | |||
| - NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh pgsql | |||
| - POSTGRES=${POSTGRES} NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh pgsql | |||
There was a problem hiding this comment.
Why is this needed? And is it not needed in https://github.com/nextcloud/server/pull/11421/files#diff-3216dfff0ed3e301453e6799e8c367e2R278 too?
MorrisJobke
approved these changes
Sep 28, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11262
For some reason the docker image does not setup the permissions correctly,
by using a different name the nextcloud installer will create the database instead
with the correct permissions
Signed-off-by: Robin Appelman robin@icewind.nl