Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parse error on editing an HTML comment #1132

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

nickvergessen
Copy link
Member

Steps

  1. Post comment " style="border: 1px solid blue;
  2. Click on "Edit comment" pencil
  3. Enjoy the blue border on your empty input

@LukasReschke as discussed
@rullzer @blizzz please review

I will create the backports

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @jancborchardt and @vincchan to be potential reviewers

@nickvergessen
Copy link
Member Author

Please while in rampage, also review the very same fix in the announcements app:
nextcloud/announcementcenter#34 + backport nextcloud/announcementcenter#35

@LukasReschke
Copy link
Member

LGTM

1 similar comment
@blizzz
Copy link
Member

blizzz commented Aug 29, 2016

LGTM

@blizzz blizzz merged commit 7278bd2 into master Aug 29, 2016
@blizzz blizzz deleted the prevent-parse-error-on-editing-an-html-comment branch August 29, 2016 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants