Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Fix icons cacher regex for compressed output #11291

Merged
merged 1 commit into from
Sep 19, 2018
Merged

[stable14] Fix icons cacher regex for compressed output #11291

merged 1 commit into from
Sep 19, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 19, 2018 •
edited
Loading

Backport of #10847

@skjnldsv
Fix icons cacher regex for compressed output
e2991d5 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: caching Related to our caching system: scssCacher, jsCombiner... labels Sep 19, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14.0.1 milestone Sep 19, 2018
@skjnldsv skjnldsv self-assigned this Sep 19, 2018
@skjnldsv skjnldsv changed the base branch from master to stable14 September 19, 2018 13:48
@nickvergessen nickvergessen mentioned this pull request Sep 19, 2018
Merged
danxuliu
danxuliu approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@danxuliu danxuliu mentioned this pull request Sep 19, 2018
Closed
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 19, 2018
@blizzz blizzz merged commit 8dff946 into stable14 Sep 19, 2018
@MorrisJobke MorrisJobke deleted the stable14-fix-icons-cacher branch October 1, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@danxuliu danxuliu danxuliu approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: scss
Projects
None yet
Milestone
Nextcloud 14.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @nickvergessen @danxuliu @blizzz