Do not show deactivated users in sharees and contacts #10543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
ignore-deactivated-users
branch
from
96b4811
to
b14cfa9
Compare
|
The second part of fixes lacks tests into |
tcitworld
added
bug
2. developing
|
@tcitworld ready for reviews? |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
ignore-deactivated-users
branch
from
b14cfa9
to
03f1fef
Compare
|
@skjnldsv Yes, it just lacks one more test. |
| @@ -106,6 +106,7 @@ public function testUpdateAndDeleteUser() { | |||
| $user->method('getUID')->willReturn('test-user'); | |||
| $user->method('getCloudId')->willReturn('cloudId'); | |||
| $user->method('getDisplayName')->willReturn('test-user'); | |||
| $user->method('isEnabled')->willReturn(true); | |||
There was a problem hiding this comment.
would be great to have a test for the false condition as well 😉
There was a problem hiding this comment.
@ChristophWurst How's that ?
There was a problem hiding this comment.
I think you just pushed what I was asking for 😉
I feel like this could probably be handled better :/ Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
added
3. to review
|
@ChristophWurst so good to go from you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part to fix #5608 : remove deactivated users from system address book.