-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login: Implements the "user disabled" message like the "wrong password" message #10322
Login: Implements the "user disabled" message like the "wrong password" message #10322
Conversation
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works and the code looks good 👍
@weeman1337 Thanks for this nice PR. The code looks nice. If you are up for some other tasks you could have a look at the "good first issues" ones https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 beside that feel free to join the IRC channel #nextcloud-dev for developer related chat. ;) |
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
29c1388
to
801bf81
Compare
I amended the commit with the acceptance tests to just fix some indentation and to set the same password for the disabled user as for the other user (consistency nitpicking ;-) ). Otherwise really nice @weeman1337, thanks a lot! |
@danxuliu does that mean the 80 chars limit from the dev docs "is adjustable"? :) |
Oh, please, you add unit tests, acceptance tests... and even read and try to abide by the dev docs? I am going to cry with joy ;-) Anyway, as Hector Barbossa would tell you :-P , the 80 char limit is more what you would call a guideline than an actual rule. Of course better to stick to it as much as possible, but it is one of those things that can be not respected in favour of better legibility or consistency. |
It now looks like the password message:
closes #9978