Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome autofill fills in password on sharelinks with login password #6821

Closed
The7thSin opened this issue Oct 12, 2017 · 7 comments
Closed

Chrome autofill fills in password on sharelinks with login password #6821

The7thSin opened this issue Oct 12, 2017 · 7 comments

Comments

@The7thSin
Copy link

Steps to reproduce

  1. Save login password for nextcloud to chrome
  2. Login and create a share link
  3. Chrome will automatically tick the password field and add your login password

Expected behaviour

Password should be set by the user if they want any

Actual behaviour

Chrome adds the login password as password for the share link

Server configuration

Operating system:
Ubuntu 16.04
Web server:
Apache2
Database:
Mariadb
PHP version:
php7.0
Nextcloud version: (see Nextcloud admin page)
12.0.3
Updated from an older Nextcloud/ownCloud or fresh install:
11.0.3

The solution is to add autocomplete=“new-password” to the password field.

@blizzz
Copy link
Member

blizzz commented Oct 12, 2017

Browser vendors are going more and more insane with their autocompletion.

The solution is to add autocomplete=“new-password” to the password field.

did you try this? Mind opening a pull request?

@The7thSin
Copy link
Author

Nope, still haven't tried it.

rullzer added a commit that referenced this issue Oct 25, 2017
Fixes #6821

This makes sure that (supported) browsers will not prefill the password
field if a user has a password saved for that nextcloud.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer self-assigned this Oct 25, 2017
@rullzer rullzer added this to the Nextcloud 13 milestone Oct 25, 2017
@rullzer
Copy link
Member

rullzer commented Oct 25, 2017

PR in #6947

@stephan-a
Copy link

Sorry but I cannot understand why this issue is already closed. When I take a look at the current master, the password input field for a shared link doesn't have the attribute autocomplete="new-password".
The password field in issue #6947 is another one, isn't it?

I have the problem with the password input field when creating a new shared link ("Choose a password for the public link").

Steps to reproduce:

  • Activate the "Share link" checkbox (but do not enter a password for the shared link)
  • Enter the username of an available user in the input field above ("Name...") whose login credentials are saved in Chrome
  • Now Chrome autofills the password input field for the shared link with the password of the entered user above

Adding the attribute autocomplete=“new-password” for the password field would fix this issue, too.

@rullzer
Copy link
Member

rullzer commented Nov 23, 2017

@stephan-a aaah I had the wrong field in mind... I'll fix this later

@rullzer rullzer reopened this Nov 23, 2017
@MorrisJobke
Copy link
Member

@rullzer Ping

@orcas-apisch
Copy link

At least as some sort of minimal protection "Share as public link" should not automatically be checked and submitted when there is a (maybe accidently typed) password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants